Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling of clusterpool default size can cause problems with unexpectedly scaling down the pool #175

Closed
chrisahl opened this issue Feb 2, 2022 · 2 comments
Assignees

Comments

@chrisahl
Copy link
Collaborator

chrisahl commented Feb 2, 2022

Tried to scale a clusterpool from 10 to 8 and for some reason the size got set to 1? I called

cm scale cp aws-4-9-sno-2x -size 8

where the -size was passed instead of --size. In this case we need to throw an error and not default to 1. This can really mess up stuff that depends on the clusterpool for OCP resources. For example, CICD

@chrisahl chrisahl changed the title Scaling of clusterpool is not working Scaling of clusterpool default size can cause problems with unexpectedly scaling down the pool Feb 2, 2022
@chrisahl
Copy link
Collaborator Author

chrisahl commented Feb 2, 2022

Think I might change the logic to default to zero and on validate if size is zero throw an error

@chrisahl
Copy link
Collaborator Author

chrisahl commented Feb 3, 2022

Fixed

@chrisahl chrisahl closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant