Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few APIs alter the headers argument #11

Closed
kum-deepak opened this issue Sep 30, 2018 · 1 comment
Closed

Few APIs alter the headers argument #11

kum-deepak opened this issue Sep 30, 2018 · 1 comment
Milestone

Comments

@kum-deepak
Copy link
Member

The code should create a copy before updating arguments. Callers would typically expect an argument to not get updated as a side effect.

Test cases will need to be added and code reviewed to cover all such cacses.

@kum-deepak kum-deepak added this to the 5.0.0 milestone Oct 1, 2018
@kum-deepak
Copy link
Member Author

Fixed in beta.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant