Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a more API-like implementation #9

Closed
philippzentner opened this issue Feb 4, 2017 · 1 comment
Closed

Consider a more API-like implementation #9

philippzentner opened this issue Feb 4, 2017 · 1 comment
Assignees

Comments

@philippzentner
Copy link
Member

So this one is from someone else:

OK so I'm trying to integrate it with my android game in Unity.
The problem I'm facing is the StomtPopup class doesn't seem to have a publicly accessible way of toggling the popup without the use of a Toggle Key - for example toggling it with an Event or with a Button.
Extending the StomtPopup class doesn't work either due to a number of key fields and methods (_ui, Show()) being private.
What I'm left with is hacking the supplied StomtPopup class itself, which is less than ideal. It would be great if your devs could consider a more API-like implementation. Maybe it's just me, but I don't like editing third party source, I much prefer extending it with my own implementation classes.
Additionally I try to actively avoid anything that checks once per frame in Update() unless I absolutely need it. I feel the implementation would be much better with an Event rather than if (Input.GetKeyDown(_toggleKey)) { on every frame. Mobile devs are paranoid about CPU cycles :slight_smile:
Otherwise the service seems solid and it's a useful way of integrating feedback. I'm yet to investigate how public the feedback is, and whether I have any way of moderating it.

@philippzentner
Copy link
Member Author

[–]JapaMala 1 Punkt vor 4 Tagen
Well, the first thing I noticed was that the rest of the game still responded to the keys I pressed when I was typing, but that's not your fault.
Also, is there a callback to show the dialog from an onscreen button?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants