Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sling-framework] Upgrade Lerna to its last version #4

Closed
1 task
biancarosa opened this issue Sep 11, 2018 · 5 comments · Fixed by #82
Closed
1 task

[Sling-framework] Upgrade Lerna to its last version #4

biancarosa opened this issue Sep 11, 2018 · 5 comments · Fixed by #82
Labels
enhancement New feature or request good first issue Good for newcomers released

Comments

@biancarosa
Copy link
Contributor

biancarosa commented Sep 11, 2018 •
edited by breakzplatform

Issue Description

There is a new version of Lerna that we could be using.

Expected Behaviour

Lerna should be upgraded to the latest version.

Checklist

  • Deployment scripts are not broken
@biancarosa biancarosa added enhancement New feature or request good first issue Good for newcomers labels Sep 11, 2018
@caiomdias caiomdias changed the title Upgrade Lerna to its last version [Sling-framework] Upgrade Lerna to its last version Oct 3, 2018
@ayr-ton
Copy link
Contributor

ayr-ton commented Oct 9, 2018

Working on this one

@ayr-ton ayr-ton mentioned this issue Oct 9, 2018
Merged
@ayr-ton
Copy link
Contributor

ayr-ton commented Oct 9, 2018

Do you prefer fixed versions instead versions with ^?
I ran the tests and nothing is failing, which workflow I could run to validate if the deployment scripts are not broken? Thank you for your time reviewing.

@breakzplatform
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ayr-ton
Copy link
Contributor

ayr-ton commented Oct 17, 2018

Is the semantic-release working as expected? 😄

@caiomdias
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Lerna to 3.4.1 ayr-ton/sling-web-framework
4 participants
@breakzplatform @ayr-ton @biancarosa @caiomdias