Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sling form regression tests #138

Closed
wants to merge 11 commits into from
Closed

Sling form regression tests #138

wants to merge 11 commits into from

Conversation

renanrbs
Copy link
Contributor

@renanrbs renanrbs commented Nov 5, 2018

Short description of what this resolves:

Adds regression test for sling form

Changes proposed in this pull request:

Uses nightwatch library and take screenshots

How to run

the first time run npm run e2e:setup
run the component with npm start sling-web-component-form
to execute the tests run npm run nightwatch

@coveralls
Copy link

coveralls commented Nov 5, 2018

Pull Request Test Coverage Report for Build 915

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.939%

Totals Coverage Status
Change from base Build 903: 0.0%
Covered Lines: 632
Relevant Lines: 989

💛 - Coveralls

andremacdowell
andremacdowell previously approved these changes Nov 5, 2018
andremacdowell
andremacdowell previously approved these changes Nov 7, 2018
Copy link
Contributor

@breakzplatform breakzplatform left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running:  main

 Error while running .locateSingleElement() protocol action: no such element: Unable to locate element: {"method":"css selector","selector":"sling-input[name="name"]"}

✖ Failed [equal]: ({ message:
   'no such element: Unable to locate element: {"method":"css selector","selector":"sling-input[name="name"]"}',
 ... == 'error') - expected "error" but got: "[object Object]"
   'no such element: Unable to locate element: {"method":"css selector","selector":"sling-input[name="name"]"}',
 ... == 'error'
    at NightwatchAPI.browser.getAttribute (/mnt/c/Users/joselito.nascimento/gits/sling-web-framework/packages/sling-web-component-form/src/component/Form.regression.test.js:23:24)
    at process._tickCallback (internal/process/next_tick.js:68:7)


FAILED: 1 assertions failed (6.773s)
   Failed [equal]: ({ message:
     'no such element: Unable to locate element: {"method":"css selector","selector":"sling-input[name="name"]"}',
   ... == 'error') - expected "error" but got: "[object Object]"
    ... == 'error'
       at NightwatchAPI.browser.getAttribute (/mnt/c/Users/joselito.nascimento/gits/sling-web-framework/packages/sling-web-component-form/src/component/Form.regression.test.js:23:24)
       at process._tickCallback (internal/process/next_tick.js:68:7)
_________________________________________________

TEST FAILURE:  1 assertions failed, 0 passed. 13.425s

 ✖ sling-web-component-form/src/component/Form.regression.test
 – main (6.773s)

   Failed [equal]: ({ message:
      'no such element: Unable to locate element: {"method":"css selector","selector":"sling-input[name="name"]"}',
    ... == 'error') - expected "error" but got: "[object Object]"
      'no such element: Unable to locate element: {"method":"css selector","selector":"sling-input[name="name"]"}',
    ... == 'error'
       at NightwatchAPI.browser.getAttribute (/mnt/c/Users/joselito.nascimento/gits/sling-web-framework/packages/sling-web-component-form/src/component/Form.regression.test.js:23:24)
       at process._tickCallback (internal/process/next_tick.js:68:7)

@renanrbs
Copy link
Contributor Author

I think this one was corrected. Can u check again @joselitojunior1 ?

@renanrbs
Copy link
Contributor Author

Sometimes the error

 Error while running .executeScript() protocol action: unknown error: Cannot read property 'querySelectorAll'
of null

happens, it looks like the script is not opening the component page, but a empty page

@leofavre leofavre deleted the feature/CMPDC-1031 branch July 3, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants