Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMPDC-1109 – New Form #187

Closed
wants to merge 145 commits into from
Closed

CMPDC-1109 – New Form #187

wants to merge 145 commits into from

Conversation

leofavre
Copy link
Contributor

@leofavre leofavre commented Dec 20, 2018

Depends on #162

Short description of what this resolves:

Exposes withForm and new sling-field components to enable users to create forms with complex validation and output.

screen shot 2018-12-20 at 16 49 30

@coveralls
Copy link

coveralls commented Dec 20, 2018

Pull Request Test Coverage Report for Build 1264

  • 5 of 10 (50.0%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.6%) to 43.59%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/sling-framework/src/framework/withEventDispatch.js 0 2 0.0%
packages/sling-helpers/src/global/globalHelper.js 3 6 50.0%
Files with Coverage Reduction New Missed Lines %
packages/sling-framework/src/framework/withEventDispatch.js 2 28.57%
packages/sling-framework/src/framework/withInitialValue.js 2 50.0%
packages/sling-framework/src/framework/withObservedProperties.js 5 59.09%
Totals Coverage Status
Change from base Build 1261: -0.6%
Covered Lines: 510
Relevant Lines: 996

💛 - Coveralls

@leofavre leofavre closed this Dec 26, 2018
@leofavre leofavre deleted the fix/form-reducers branch July 3, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants