Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many RequestMaker components: HttpRequest, TryIt, RequestMaker #273

Closed
marcelltoth opened this issue Mar 2, 2020 · 3 comments · Fixed by #723
Closed

Too many RequestMaker components: HttpRequest, TryIt, RequestMaker #273

marcelltoth opened this issue Mar 2, 2020 · 3 comments · Fixed by #723
Assignees
Milestone

Comments

@marcelltoth
Copy link
Contributor

There are way too many components that render request-makers.

To make things worse, HttpRequest has the same TryIt displayName, so it can be really hard to know which one we're using at the moment.

Their props are similar but somewhat different.

@marcelltoth
Copy link
Contributor Author

I'm reviving this because it makes for a good preparatory task before beginning to work on the new TryIt component.

If we got rid of all the extra RM components - especially TryIt - we could differentiate between the two versions of the component both in writing and in the code:

  • RequestMaker would be the old one
  • TryIt would be the new (Product's materials are already calling it TryIt which makes this simpler)

@philsturgeon
Copy link
Contributor

Request Maker would be the full, all options included, HTTP console. This would be the basis for the new Requests Module in Platform / Studio someday.

"Try It" is the simple "click a button to send the request that was mostly defined by somebody else" component, which is RequestMaker-lite.

@marcelltoth
Copy link
Contributor Author

marcelltoth commented Oct 26, 2020

Hold on, so there are two new components being built? We are likely missing / misunderstanding a significant part of the request maker plans then. Let's discuss this tomorrow.

cc @stoplightio/undefined

@marcelltoth marcelltoth changed the title chore: too many RequestMaker components: HttpRequest, TryIt, RequestMaker Too many RequestMaker components: HttpRequest, TryIt, RequestMaker Nov 3, 2020
@marcelltoth marcelltoth added this to the 2020-11-03 milestone Nov 3, 2020
@marcelltoth marcelltoth self-assigned this Nov 5, 2020
@mmiask mmiask modified the milestones: 2020-11-03, 2020-11-17 Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants