Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oas3): adds webhook support for oas 3.1 #258

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

daniel-white
Copy link
Member

@daniel-white daniel-white commented Dec 11, 2023

this is a set of changes to support oas 3.1 webhooks. this does have breaking changes to make the operation parsing compatible both with regular operations and webhooks.

@daniel-white daniel-white requested review from a team, brendarearden, matthewmurphy and P0lip and removed request for a team December 11, 2023 17:49
@daniel-white daniel-white marked this pull request as ready for review December 11, 2023 17:49
export type PostmanCollectionHttpOperationTransformer = HttpEndpointOperationTransformer<
{
document: CollectionDefinition;
path: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be name: string; and not path: string;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this one should be fine

Copy link
Contributor

@brendarearden brendarearden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@daniel-white daniel-white changed the title feat(oas3): adds webhook support BREAKING CHANGE: adds webhook support for oas 3.1 Dec 12, 2023
@daniel-white daniel-white changed the title BREAKING CHANGE: adds webhook support for oas 3.1 feat(oas3): adds webhook support for oas 3.1 Dec 12, 2023
@daniel-white daniel-white merged commit 1cc34ec into master Dec 12, 2023
3 checks passed
@daniel-white daniel-white deleted the feat/oas3.1-webhooks branch December 12, 2023 15:13
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants