-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dark mode validations #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that @marcelltoth was removing some mosaic elements from JSV to reduce render times.
Maybe you two can collaborate to test if/how this change affects performance?
Unless @marcelltoth believes that it will be a non-issue here of course :)
That was my only worrying thought as well. 😄 Let's see how the stress schema renders. Maybe it's not that bad as it's only validations. 🤔 |
Well, it seems to render fine from what I can see. I added those mosaic components by the way, so we can keep it the way it was, just use it for validations where it's necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a rough measurement now. It's worse, but not horrible, around ~5-10%. I'm OK with it if you are.
🎉 This PR is included in version 4.0.0-beta.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Needed for: stoplightio/elements#1149
Makes validations values support dark mode