Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dark mode validations #147

Merged
merged 2 commits into from
May 31, 2021
Merged

fix: dark mode validations #147

merged 2 commits into from
May 31, 2021

Conversation

mallachari
Copy link
Contributor

Needed for: stoplightio/elements#1149

Makes validations values support dark mode

Screenshot from 2021-05-31 13-06-51

@mallachari mallachari requested a review from a team May 31, 2021 11:17
@mallachari mallachari self-assigned this May 31, 2021
@mallachari mallachari requested review from a team, mpodlasin and billiegoose May 31, 2021 11:17
Copy link
Contributor

@mpodlasin mpodlasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that @marcelltoth was removing some mosaic elements from JSV to reduce render times.

Maybe you two can collaborate to test if/how this change affects performance?

Unless @marcelltoth believes that it will be a non-issue here of course :)

@marcelltoth
Copy link
Contributor

I know that @marcelltoth was removing some mosaic elements from JSV to reduce render times.

Maybe you two can collaborate to test if/how this change affects performance?

That was my only worrying thought as well. 😄 Let's see how the stress schema renders. Maybe it's not that bad as it's only validations. 🤔

@mallachari
Copy link
Contributor Author

I know that @marcelltoth was removing some mosaic elements from JSV to reduce render times.
Maybe you two can collaborate to test if/how this change affects performance?

That was my only worrying thought as well. Let's see how the stress schema renders. Maybe it's not that bad as it's only validations.

Well, it seems to render fine from what I can see. I added those mosaic components by the way, so we can keep it the way it was, just use it for validations where it's necessary.

Copy link
Contributor

@marcelltoth marcelltoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a rough measurement now. It's worse, but not horrible, around ~5-10%. I'm OK with it if you are.

@mallachari mallachari merged commit 12a4601 into beta May 31, 2021
@mallachari mallachari deleted the fix/dark-mode-validations branch May 31, 2021 13:11
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-beta.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants