fix: display title instead of any for combiners #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@P0lip @mnaumanali94 any chance ya'll could take a look at this in the near future? Thank you! |
9 tasks
P0lip
approved these changes
May 25, 2023
Co-authored-by: Jakub Rożek <jakub@rozek.tech>
P0lip
added a commit
that referenced
this pull request
May 30, 2023
* fix: display title instead of any for combiners * fix: remove as string in favor of string construction Co-authored-by: Jakub Rożek <jakub@rozek.tech> --------- Co-authored-by: Jakub Rożek <jakub@rozek.tech>
|
Thank you <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#InsertIssueNumberHere
fixes #223
Description
When rendering a combiner's children, we want to show the title if there is one.
How Has This Been Tested?
with the provided schema fixture inside of storybook
Screenshot(s)/recordings(s)
see linked issue
Types of changes
Checklist