Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(pegjs): optimize for speed #17

Merged
merged 2 commits into from Feb 6, 2020
Merged

perf(pegjs): optimize for speed #17

merged 2 commits into from Feb 6, 2020

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Feb 6, 2020

optimize=speed image

-rw-rw-r-- 1 p0lip p0lip  25K lut  6 21:00 index.cjs.js
-rw-rw-r-- 1 p0lip p0lip  503 lut  6 21:00 index.d.ts
-rw-rw-r-- 1 p0lip p0lip  24K lut  6 21:00 index.es.js

optimize=size
image

-rw-rw-r-- 1 p0lip p0lip  23K lut  6 20:56 index.cjs.js
-rw-rw-r-- 1 p0lip p0lip  503 lut  6 20:56 index.d.ts
-rw-rw-r-- 1 p0lip p0lip  22K lut  6 20:56 index.es.js

same project, just the initial processing part.

It isn't much of a win, but given there is no work involved, let's ship it.
Found when working on https://github.com/stoplightio/platform-internal/pull/873

@P0lip P0lip self-assigned this Feb 6, 2020
Copy link
Member

@billiegoose billiegoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, doesn't look like it was saving much size. But more than doubling in speed, wow!

@billiegoose billiegoose merged commit 208fd8c into master Feb 6, 2020
@billiegoose billiegoose deleted the perf/speed-build branch February 6, 2020 15:43
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 1.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants