fix(http-server): discard request body if the content-length header i…

[acolombier]

Addresses #2102

Summary

This PR changes the condition of the HTTP server resolving the request body. It assumes that the body is null in case of an explicit Content-Length: 0.

Since in #1990 the decision was made to assume no body in case of no explicit Content-Length other than zero (omitting will assume no body - which seems matching the HTTP/1.1 spec), however I didn't follow the same approach as it could be seen as a minor changes (as apposite to a patch).

Let me know if you would like me to default it to 0 in case if missing as well!

Checklist

• The basics
  • I tested these changes manually in my local or dev environment (Running + Docker)
• Tests
  • Added or updated
  • N/A
• Event Tracking
  • I added event tracking and followed the event tracking guidelines
  • N/A
• Error Reporting
  • I reported errors and followed the error reporting guidelines
  • N/A

Screenshots

Before

After

Additional context

N/A

[acolombier]

I have taken the freedom to add a NVM RC file. Let me know if you would like this out

[chohmann]

@acolombier thanks so much for the PR! I think we need to make just one small change to keep the spirit of the test the same.

[chohmann]

It might be better to update this test to have one of the required properties (either id or status) so that the spirit of the test is still the same: throws error if there's a missing required property in the body. Otherwise this test now changes to testing the behavior if the body is missing completely.

[acolombier]

I believe there is a problem:

• The body used to be optional (thus change at line 689)
• There body required check and the content assertion happens at two different places

My understanding of the describe/it is that this unit test might not have been covering the part it says it does.

I have made a change which I think should reflect a bit better the usecase this test was meant to test. The body required check seems to already be covered by this test, but happy to add an other one if you think it should have thorough testing.

[chohmann]

Thanks for updating the test! This looks good to me. Thank you for your contribution!

[chohmann]

This has been released in version 4.10.2 🎉

[childish-sambino]

@chohmann This looks to be causing a breakage where requests are accepted when no body is provided, but the body is defined as having one or more required parameters and should thus be rejected.