fix: prevent ruleset to be mutated

SL-786 - deep cloning the provided rulset
stoplightio · Dec 3, 2018 · a793b6c · a793b6c
1 parent e25d46f
commit a793b6c
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 2 deletions.
diff --git a/src/__tests__/spectral.test.ts b/src/__tests__/spectral.test.ts
@@ -14,6 +14,55 @@ describe('spectral', () => {
     expect(results.length).toBeGreaterThan(0);
   });
 
+  test('setting rules should not mutate the original ruleset', () => {
+    const givenCustomRuleSet = {
+      rules: {
+        oas2: {
+          rule1: {
+            type: RuleType.STYLE,
+            function: RuleFunction.TRUTHY,
+            path: '$',
+            enabled: true,
+            summary: '',
+            input: {
+              properties: 'something',
+            },
+          },
+        },
+      },
+    };
+    const expectedCustomRuleSet = {
+      rules: {
+        oas2: {
+          rule1: {
+            type: RuleType.STYLE,
+            function: RuleFunction.TRUTHY,
+            path: '$',
+            enabled: true,
+            summary: '',
+            input: {
+              properties: 'something',
+            },
+          },
+        },
+      },
+    };
+
+    const s = new Spectral({ rulesets: [givenCustomRuleSet] });
+
+    s.setRules([
+      {
+        rules: {
+          oas2: {
+            rule1: false,
+          },
+        },
+      },
+    ]);
+
+    expect(expectedCustomRuleSet).toEqual(givenCustomRuleSet);
+  });
+
   test('be able to toggle rules on apply', () => {
     const spec = {
       hello: 'world',

diff --git a/src/index.ts b/src/index.ts
@@ -92,7 +92,7 @@ export class Spectral {
   }
 
   public setRules(rulesets: types.IRuleset[]) {
-    this._rulesets = rulesets;
+    this._rulesets = merge([], rulesets);
     this._functions = this._rulesetsToFunctions(this._rulesets);
     this._rules = this._rulesetsToRules(this._rulesets);
   }
@@ -126,7 +126,7 @@ export class Spectral {
           if (rule.path !== path) {
             console.warn(
               `Rule '${ruleName} was categorized under an incorrect path. Was under ${path}, but rule path is set to ${
-                rule.path
+              rule.path
               }`
             );
             continue;