Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parsing errors #118

Merged
merged 2 commits into from
Mar 28, 2019
Merged

feat: parsing errors #118

merged 2 commits into from
Mar 28, 2019

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Mar 28, 2019

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

This is post 2.0, most likely :)

image

Parsing errors are included in validation results.

What is the current behavior?

Parsing errors are ignored.

Other information

(e.g. detailed explanation, related issues, links for us to have context, eg. stackoverflow, issues outside of the repo, forum, etc.)

@P0lip P0lip changed the title Feat/parsing errors feat: parsing errors Mar 28, 2019
Copy link
Contributor

@philsturgeon philsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a test for this? I believe you, but... you know. 😓

@P0lip
Copy link
Contributor Author

P0lip commented Mar 28, 2019

@philsturgeon
Changed the implementation a bit so that the results can be accessed programmatically.

@philsturgeon philsturgeon merged commit 959b5f5 into release/2.0 Mar 28, 2019
@philsturgeon philsturgeon deleted the feat/parsing-errors branch March 28, 2019 13:54
philsturgeon pushed a commit that referenced this pull request Mar 28, 2019
* feat: bump @stoplight/yaml

* feat: list YAMLExceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants