feat(cli): integrate ruleset-bundler #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2021
P0lip
force-pushed
the
feat/cli/integrate-ruleset-bundler
branch
2 times, most recently
from
808b061
to
060247a
Compare
P0lip
force-pushed
the
feat/cli/integrate-ruleset-bundler
branch
from
7ae93fc
to
5937582
Compare
P0lip
force-pushed
the
feat/cli/integrate-ruleset-bundler
branch
from
5937582
to
2c91908
Compare
P0lip
commented
Oct 5, 2021
| @@ -212,7 +212,9 @@ describe('Linter service', () => { | |||
|
|
|||
| describe('when single ruleset option provided', () => { | |||
| it('outputs "does not exist" error', () => { | |||
| return expect(run(`lint ${validOas3SpecPath} -r non-existent-path`)).rejects.toThrow('Cannot find module'); | |||
| return expect(run(`lint ${validOas3SpecPath} -r non-existent-path`)).rejects.toThrow( | |||
| /^Could not resolve entry module \(packages[/\\]cli[/\\]src[/\\]services[/\\]__tests__[/\\]__fixtures__[/\\]non-existent-path\)\.$/, | |||
There was a problem hiding this comment.
this regexp is because of Windows and their slashes
marbemac
reviewed
Oct 5, 2021
P0lip
commented
Oct 6, 2021
| import * as commonjs from '@rollup/plugin-commonjs'; | ||
| import { ErrorWithCause } from 'pony-cause'; |
There was a problem hiding this comment.
marbemac
approved these changes
Oct 6, 2021
stoplight-bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
# [@stoplight/spectral-cli-v6.1.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-cli-v6.0.1...@stoplight/spectral-cli-v6.1.0) (2021-10-07) ### Features * **cli:** integrate ruleset-bundler ([#1824](#1824)) ([26284c7](26284c7))
|
🎉 This PR is included in version @stoplight/spectral-cli-v6.1.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/stoplightio/platform-internal/issues/7847
Fixes #1821
Checklist
Does this PR introduce a breaking change?