Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): update nimma #1829

Merged
merged 3 commits into from
Sep 13, 2021
Merged

chore(core): update nimma #1829

merged 3 commits into from
Sep 13, 2021

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Sep 13, 2021

Here's the whole diff P0lip/nimma@0.1.1...0.1.3
A list of commits interesting from Spectral's point of view:
P0lip/nimma@a6ffabe
P0lip/nimma@22105d3
P0lip/nimma@43bf386
P0lip/nimma@8598021
P0lip/nimma@4f77265
P0lip/nimma@d32d4ca

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Additional context

I set up some simple REPL where one can check out the code live

@P0lip P0lip self-assigned this Sep 13, 2021
@P0lip P0lip added the dependencies Pull requests that update a dependency file label Sep 13, 2021
@P0lip P0lip force-pushed the fix/core/nimma-update branch 3 times, most recently from 8ab43ee to 47ff2a6 Compare September 13, 2021 20:34
@@ -52,6 +52,40 @@ describe('linter', () => {
return expect(spectral.run('123')).resolves.toEqual([]);
});

test('given @ in the property key, should still lint as normal', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for #1827

@P0lip P0lip requested a review from marbemac September 13, 2021 20:37
Copy link
Contributor

@marbemac marbemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@P0lip P0lip merged commit 4e8da71 into develop Sep 13, 2021
@P0lip P0lip deleted the fix/core/nimma-update branch September 13, 2021 21:55
stoplight-bot pushed a commit that referenced this pull request Sep 14, 2021
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-core-v1.5.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants