Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(functions): revamp Ajv integration #1845

Merged
merged 7 commits into from
Oct 19, 2021
Merged

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Sep 22, 2021

Fixes #1885

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

A list of changes:

  • we try to reuse the validator fn if we generated one for the same schema - currently we always create a new one unless a scheme has $id. documentInventory is stable enough to serve us. It's lifespan should be equal to a single run execution, so basically a single lint process.
  • meta draft has been removed in favor of https://www.npmjs.com/package/ajv-draft-04
  • bumped some related deps

@P0lip P0lip self-assigned this Sep 22, 2021
@P0lip P0lip force-pushed the fix/functions/leaking-ajv branch 2 times, most recently from 555e3a3 to 3bbee09 Compare September 22, 2021 12:59
@P0lip P0lip marked this pull request as ready for review October 18, 2021 18:27
@P0lip P0lip requested a review from marbemac October 18, 2021 18:27
@P0lip P0lip changed the title fix(functions): revamp Ajv integration feat(functions): revamp Ajv integration Oct 18, 2021
Copy link
Contributor

@domagojk domagojk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P0lip P0lip enabled auto-merge (squash) October 19, 2021 14:43
@P0lip P0lip merged commit a958000 into develop Oct 19, 2021
@P0lip P0lip deleted the fix/functions/leaking-ajv branch October 19, 2021 14:48
stoplight-bot pushed a commit that referenced this pull request Oct 20, 2021
# [@stoplight/spectral-functions-v1.4.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-functions-v1.3.0...@stoplight/spectral-functions-v1.4.0) (2021-10-20)

### Features

* **functions:** revamp Ajv integration ([#1845](#1845)) ([a958000](a958000))
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-functions-v1.4.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memory leak in schema function
3 participants