feat(rulesets): add validation rule for oas2 discriminator #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
approved these changes
Nov 2, 2021
| import type { IFunction, IFunctionResult } from '@stoplight/spectral-core'; | ||
| import { isObject } from './utils/isObject'; | ||
|
|
||
| export const oasDiscriminator: IFunction = (schema, _opts, { path }) => { |
There was a problem hiding this comment.
Could probably use createRulesetFunction from @stoplight/spectral-core to simplify things a bit here, but it's OK the way it is.
Examples:
https://github.com/stoplightio/spectral/blob/develop/packages/functions/src/alphabetical.ts#L42
https://github.com/stoplightio/spectral/blob/e71cf134866e22665a2cb4d8635d1b4c98a5ed95/docs/guides/5-custom-functions.md#validating-options
stoplight-bot
pushed a commit
that referenced
this pull request
Nov 2, 2021
# [@stoplight/spectral-rulesets-v1.3.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-rulesets-v1.2.7...@stoplight/spectral-rulesets-v1.3.0) (2021-11-02) ### Features * **rulesets:** add validation rule for oas2 discriminator ([#1921](#1921)) ([f4e172e](f4e172e))
|
🎉 This PR is included in version @stoplight/spectral-rulesets-v1.3.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an oas rule to check compliance with discriminator definition in OpenAPI v2.
Checklist
Does this PR introduce a breaking change?
Screenshots
If applicable, add screenshots or gifs to help demonstrate the changes. If not applicable, remove this screenshots section before creating the PR.
Additional context
Add any other context about the pull request here. Remove this section if there is no additional context.