Set _supported_filesystems in BlivetGUIAnaconda init #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlivetGUIAnaconda subclasses BlivetGUI, but doesn't call the parent class's __init__. c4b6e17 added supported_filesystems to BlivetGUI and set _supported_filesystems for caching during __init__, but this was not also added to BlivetGUIAnaconda, so when anything tries to use the supported_filesystems property of a BlivetGUIAnaconda instance, it will crash. This is causing all attempts to use blivet-gui in anaconda to crash since 2.1.8 landed in Rawhide. Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
Note: haven't tested this as it's slightly difficult to do, but I think this should be a sufficient fix, from just looking at the code. |
|
Jenkins, ok to test. |
halstead
pushed a commit
to openembedded/meta-openembedded
that referenced
this pull request
Mar 25, 2019
Fix the following error when attempting to use blivet-gui in anaconda:
Traceback (most recent call first):
File "/usr/lib64/python3.5/site-packages/blivetgui/blivetgui.py", line 153, in supported_filesystems
if self._supported_filesystems:
File "/usr/lib64/python3.5/site-packages/blivetgui/blivetgui.py", line 456, in add_device
supported_filesystems=self.supported_filesystems,
AttributeError: 'BlivetGUIAnaconda' object has no attribute '_supported_filesystems'
Reference:
storaged-project/blivet-gui#100
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
jpuhlman
pushed a commit
to MontaVista-OpenSourceTechnology/meta-openembedded
that referenced
this pull request
Apr 17, 2019
Source: meta-openembedded MR: '00000' Type: Integration Disposition: Merged from meta-openembedded ChangeID: f8af6c4 Description: Fix the following error when attempting to use blivet-gui in anaconda: Traceback (most recent call first): File "/usr/lib64/python3.5/site-packages/blivetgui/blivetgui.py", line 153, in supported_filesystems if self._supported_filesystems: File "/usr/lib64/python3.5/site-packages/blivetgui/blivetgui.py", line 456, in add_device supported_filesystems=self.supported_filesystems, AttributeError: 'BlivetGUIAnaconda' object has no attribute '_supported_filesystems' Reference: storaged-project/blivet-gui#100 Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com> Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Jeremy Puhlman <jpuhlman@mvista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlivetGUIAnaconda subclasses BlivetGUI, but doesn't call the
parent class's init. c4b6e17 added supported_filesystems
to BlivetGUI and set _supported_filesystems for caching during
init, but this was not also added to BlivetGUIAnaconda, so
when anything tries to use the supported_filesystems property
of a BlivetGUIAnaconda instance, it will crash. This is causing
all attempts to use blivet-gui in anaconda to crash since 2.1.8
landed in Rawhide.
Signed-off-by: Adam Williamson awilliam@redhat.com