Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unknown service handler option for server #12

Closed
vtolstov opened this issue May 26, 2021 · 4 comments
Closed

unknown service handler option for server #12

vtolstov opened this issue May 26, 2021 · 4 comments

Comments

@vtolstov
Copy link

https://pkg.go.dev/google.golang.org/grpc?utm_source=godoc#UnknownServiceHandler

i'm really need this to be able to dynamically add handlers and also have ability to send custom response for unknown handler.
can you implements something like this in drpc ?

@zeebo
Copy link
Collaborator

zeebo commented Jun 9, 2021

Do you also need to be able to dynamically remove handlers? It seems like it shouldn't be hard to add a fallback to drpcmux.Mux for unknown handlers. It would just check here: https://github.com/storj/drpc/blob/main/drpcmux/handle_rpc.go#L18

@vtolstov
Copy link
Author

vtolstov commented Jun 9, 2021

wow you code looks like in micro framework =) so i need to implement Mux interface and all will works. thanks

@zeebo
Copy link
Collaborator

zeebo commented Jun 9, 2021

Yep, a lot of effort was spent trying to make it all a bunch of composable interfaces to let people do their own things instead of having the library have to contain it all.

Given that you said you'd just implement it locally, I'm closing. Thanks!

@zeebo zeebo closed this as completed Jun 9, 2021
@vtolstov
Copy link
Author

vtolstov commented Jun 9, 2021

yeah, thanks for support. after i'm add it to my framework i'm test it performance =)
i have similar use-case as you (i'm transfer rdp/spice binary data between endpoints)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants