Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway-MT: Re-evaluate logging #31

Open
wthorp opened this issue Sep 28, 2021 · 2 comments
Open

Gateway-MT: Re-evaluate logging #31

wthorp opened this issue Sep 28, 2021 · 2 comments
Labels
edge observability toil needs to be worked on overtime

Comments

@wthorp
Copy link
Contributor

wthorp commented Sep 28, 2021

We currently use a global Sync.Once mutex with the Minio logger. The need to copy things between context and use of globals is unfortunate. Could we simplify the logging solution if we use our own middleware? Maybe we would have to implement a custom RegisterAPIRouter equivalent; Bill had one at one point that included all the routes and was hand written, not derived from Minio.

@halkyon halkyon self-assigned this Oct 6, 2021
@wthorp wthorp changed the title Re-evaluate logging Gateway-MT: Re-evaluate logging Oct 12, 2021
@halkyon halkyon removed their assignment Apr 12, 2022
@ferristocrat
Copy link
Contributor

@amwolff @halkyon - is this still relevant?

@halkyon
Copy link
Contributor

halkyon commented Oct 30, 2022

@ferristocrat Yes, there is still a need to clean this up by removing the minio logging dependency ("gwlog") in our logging/metrics middleware. This should be labelled as technical debt or whatever label we want to use to describe it to that effect.

@amwolff amwolff added the toil needs to be worked on overtime label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edge observability toil needs to be worked on overtime
Projects
No open projects
Status: Backlog
Development

No branches or pull requests

4 participants