-
Notifications
You must be signed in to change notification settings - Fork 390
/
repairqueue.go
360 lines (323 loc) · 11 KB
/
repairqueue.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
// Copyright (C) 2019 Storj Labs, Inc.
// See LICENSE for copying information.
package satellitedb
import (
"context"
"database/sql"
"errors"
"fmt"
"strings"
"time"
"github.com/zeebo/errs"
"storj.io/common/storj"
"storj.io/common/uuid"
"storj.io/private/dbutil"
"storj.io/private/dbutil/pgutil"
"storj.io/storj/satellite/metabase"
"storj.io/storj/satellite/repair/queue"
"storj.io/storj/satellite/satellitedb/dbx"
)
// RepairQueueSelectLimit defines how many items can be selected at the same time.
const RepairQueueSelectLimit = 1000
// repairQueue implements storj.io/storj/satellite/repair/queue.RepairQueue.
type repairQueue struct {
db *satelliteDB
}
// Stat returns stat of the current queue state.
func (r *repairQueue) Stat(ctx context.Context) ([]queue.Stat, error) {
query := `
select placement,
count(1),
max(inserted_at) as max_inserted_at,
min(inserted_at) as min_inserted_at,
max(attempted_at) as max_attempted_at,
min(attempted_at) as min_attempted_at,
max(segment_health) as max_health,
min(segment_health) as min_health
from repair_queue
group by placement, attempted_at is null`
rows, err := r.db.QueryContext(ctx, query)
if err != nil {
return nil, err
}
defer func() { err = errs.Combine(err, rows.Close()) }()
var res []queue.Stat
for rows.Next() {
var stat queue.Stat
err = rows.Scan(
&stat.Placement,
&stat.Count,
&stat.MaxInsertedAt,
&stat.MinInsertedAt,
&stat.MaxAttemptedAt,
&stat.MinAttemptedAt,
&stat.MaxSegmentHealth,
&stat.MinSegmentHealth,
)
if err != nil {
return res, err
}
res = append(res, stat)
}
return res, rows.Err()
}
func (r *repairQueue) Insert(ctx context.Context, seg *queue.InjuredSegment) (alreadyInserted bool, err error) {
defer mon.Task()(&ctx)(&err)
// insert if not exists, or update healthy count if does exist
var query string
// we want to insert the segment if it is not in the queue, but update the segment health if it already is in the queue
// we also want to know if the result was an insert or an update - this is the reasoning for the xmax section of the postgres query
// and the separate cockroach query (which the xmax trick does not work for)
switch r.db.impl {
case dbutil.Postgres:
query = `
INSERT INTO repair_queue
(
stream_id, position, segment_health, placement
)
VALUES (
$1, $2, $3, $4
)
ON CONFLICT (stream_id, position)
DO UPDATE
SET segment_health=$3, updated_at=current_timestamp, placement=$4
RETURNING (xmax != 0) AS alreadyInserted
`
case dbutil.Cockroach:
// TODO it's not optimal solution but crdb is not used in prod for repair queue
query = `
WITH inserted AS (
SELECT count(*) as alreadyInserted FROM repair_queue
WHERE stream_id = $1 AND position = $2
)
INSERT INTO repair_queue
(
stream_id, position, segment_health, placement
)
VALUES (
$1, $2, $3, $4
)
ON CONFLICT (stream_id, position)
DO UPDATE
SET segment_health=$3, updated_at=current_timestamp, placement=$4
RETURNING (SELECT alreadyInserted FROM inserted)
`
}
rows, err := r.db.QueryContext(ctx, query, seg.StreamID, seg.Position.Encode(), seg.SegmentHealth, seg.Placement)
if err != nil {
return false, err
}
defer func() { err = errs.Combine(err, rows.Close()) }()
if !rows.Next() {
// cockroach query does not return anything if the segment is already in the queue
alreadyInserted = true
} else {
err = rows.Scan(&alreadyInserted)
if err != nil {
return false, err
}
}
return alreadyInserted, rows.Err()
}
func (r *repairQueue) InsertBatch(
ctx context.Context,
segments []*queue.InjuredSegment,
) (newlyInsertedSegments []*queue.InjuredSegment, err error) {
defer mon.Task()(&ctx)(&err)
if len(segments) == 0 {
return nil, nil
}
// insert if not exists, or update healthy count if does exist
var query string
// we want to insert the segment if it is not in the queue, but update the segment health if it already is in the queue
// we also want to know if the result was an insert or an update - this is the reasoning for the xmax section of the postgres query
// and the separate cockroach query (which the xmax trick does not work for)
switch r.db.impl {
case dbutil.Postgres:
query = `
INSERT INTO repair_queue
(
stream_id, position, segment_health, placement
)
VALUES (
UNNEST($1::BYTEA[]),
UNNEST($2::INT8[]),
UNNEST($3::double precision[]),
UNNEST($4::INT2[])
)
ON CONFLICT (stream_id, position)
DO UPDATE
SET segment_health=EXCLUDED.segment_health, updated_at=current_timestamp, placement=EXCLUDED.placement
RETURNING NOT(xmax != 0) AS newlyInserted
`
case dbutil.Cockroach:
// TODO it's not optimal solution but crdb is not used in prod for repair queue
query = `
WITH to_insert AS (
SELECT
UNNEST($1::BYTEA[]) AS stream_id,
UNNEST($2::INT8[]) AS position,
UNNEST($3::double precision[]) AS segment_health,
UNNEST($4::INT2[]) AS placement
),
do_insert AS (
INSERT INTO repair_queue (
stream_id, position, segment_health, placement
)
SELECT stream_id, position, segment_health, placement
FROM to_insert
ON CONFLICT (stream_id, position)
DO UPDATE
SET
segment_health=EXCLUDED.segment_health,
updated_at=current_timestamp,
placement=EXCLUDED.placement
RETURNING false
)
SELECT
(repair_queue.stream_id IS NULL) AS newlyInserted
FROM to_insert
LEFT JOIN repair_queue
ON to_insert.stream_id = repair_queue.stream_id
AND to_insert.position = repair_queue.position
`
}
var insertData struct {
StreamIDs []uuid.UUID
Positions []int64
SegmentHealths []float64
placements []int16
}
for _, segment := range segments {
insertData.StreamIDs = append(insertData.StreamIDs, segment.StreamID)
insertData.Positions = append(insertData.Positions, int64(segment.Position.Encode()))
insertData.SegmentHealths = append(insertData.SegmentHealths, segment.SegmentHealth)
insertData.placements = append(insertData.placements, int16(segment.Placement))
}
rows, err := r.db.QueryContext(
ctx, query,
pgutil.UUIDArray(insertData.StreamIDs),
pgutil.Int8Array(insertData.Positions),
pgutil.Float8Array(insertData.SegmentHealths),
pgutil.Int2Array(insertData.placements),
)
if err != nil {
return newlyInsertedSegments, err
}
defer func() { err = errs.Combine(err, rows.Close()) }()
i := 0
for rows.Next() {
var isNewlyInserted bool
err = rows.Scan(&isNewlyInserted)
if err != nil {
return newlyInsertedSegments, err
}
if isNewlyInserted {
newlyInsertedSegments = append(newlyInsertedSegments, segments[i])
}
i++
}
return newlyInsertedSegments, rows.Err()
}
func (r *repairQueue) Select(ctx context.Context, includedPlacements []storj.PlacementConstraint, excludedPlacements []storj.PlacementConstraint) (seg *queue.InjuredSegment, err error) {
defer mon.Task()(&ctx)(&err)
restriction := ""
placementsToString := func(placements []storj.PlacementConstraint) string {
var ps []string
for _, p := range placements {
ps = append(ps, fmt.Sprintf("%d", p))
}
return strings.Join(ps, ",")
}
if len(includedPlacements) > 0 {
restriction += fmt.Sprintf(" AND placement IN (%s)", placementsToString(includedPlacements))
}
if len(excludedPlacements) > 0 {
restriction += fmt.Sprintf(" AND placement NOT IN (%s)", placementsToString(excludedPlacements))
}
segment := queue.InjuredSegment{}
switch r.db.impl {
case dbutil.Cockroach:
err = r.db.QueryRowContext(ctx, `
UPDATE repair_queue SET attempted_at = now()
WHERE (attempted_at IS NULL OR attempted_at < now() - interval '6 hours') `+restriction+`
ORDER BY segment_health ASC, attempted_at NULLS FIRST
LIMIT 1
RETURNING stream_id, position, attempted_at, updated_at, inserted_at, segment_health, placement
`).Scan(&segment.StreamID, &segment.Position, &segment.AttemptedAt,
&segment.UpdatedAt, &segment.InsertedAt, &segment.SegmentHealth, &segment.Placement)
case dbutil.Postgres:
err = r.db.QueryRowContext(ctx, `
UPDATE repair_queue SET attempted_at = now() WHERE (stream_id, position) = (
SELECT stream_id, position FROM repair_queue
WHERE (attempted_at IS NULL OR attempted_at < now() - interval '6 hours') `+restriction+`
ORDER BY segment_health ASC, attempted_at NULLS FIRST FOR UPDATE SKIP LOCKED LIMIT 1
) RETURNING stream_id, position, attempted_at, updated_at, inserted_at, segment_health, placement
`).Scan(&segment.StreamID, &segment.Position, &segment.AttemptedAt,
&segment.UpdatedAt, &segment.InsertedAt, &segment.SegmentHealth, &segment.Placement)
default:
return seg, errs.New("unhandled database: %v", r.db.impl)
}
if err != nil {
if errors.Is(err, sql.ErrNoRows) {
return nil, queue.ErrEmpty.New("")
}
return nil, err
}
return &segment, err
}
func (r *repairQueue) Delete(ctx context.Context, seg *queue.InjuredSegment) (err error) {
defer mon.Task()(&ctx)(&err)
_, err = r.db.ExecContext(ctx, r.db.Rebind(`DELETE FROM repair_queue WHERE stream_id = ? AND position = ?`), seg.StreamID, seg.Position.Encode())
return Error.Wrap(err)
}
func (r *repairQueue) Clean(ctx context.Context, before time.Time) (deleted int64, err error) {
defer mon.Task()(&ctx)(&err)
n, err := r.db.Delete_RepairQueue_By_UpdatedAt_Less(ctx, dbx.RepairQueue_UpdatedAt(before))
return n, Error.Wrap(err)
}
func (r *repairQueue) SelectN(ctx context.Context, limit int) (segs []queue.InjuredSegment, err error) {
defer mon.Task()(&ctx)(&err)
if limit <= 0 || limit > RepairQueueSelectLimit {
limit = RepairQueueSelectLimit
}
// TODO: strictly enforce order-by or change tests
rows, err := r.db.QueryContext(ctx,
r.db.Rebind(`SELECT stream_id, position, attempted_at, updated_at, segment_health, placement
FROM repair_queue LIMIT ?`), limit,
)
if err != nil {
return nil, Error.Wrap(err)
}
defer func() { err = errs.Combine(err, rows.Close()) }()
for rows.Next() {
var seg queue.InjuredSegment
err = rows.Scan(&seg.StreamID, &seg.Position, &seg.AttemptedAt,
&seg.UpdatedAt, &seg.SegmentHealth, &seg.Placement)
if err != nil {
return segs, Error.Wrap(err)
}
segs = append(segs, seg)
}
return segs, Error.Wrap(rows.Err())
}
func (r *repairQueue) Count(ctx context.Context) (count int, err error) {
defer mon.Task()(&ctx)(&err)
// Count every segment regardless of how recently repair was last attempted
err = r.db.QueryRowContext(ctx, r.db.Rebind(`SELECT COUNT(*) as count FROM repair_queue`)).Scan(&count)
return count, Error.Wrap(err)
}
// TestingSetAttemptedTime sets attempted time for a segment.
func (r *repairQueue) TestingSetAttemptedTime(ctx context.Context, streamID uuid.UUID,
position metabase.SegmentPosition, t time.Time) (rowsAffected int64, err error) {
defer mon.Task()(&ctx)(&err)
res, err := r.db.ExecContext(ctx,
r.db.Rebind(`UPDATE repair_queue SET attempted_at = ? WHERE stream_id = ? AND position = ?`),
t, streamID, position.Encode(),
)
if err != nil {
return 0, Error.Wrap(err)
}
count, err := res.RowsAffected()
return count, Error.Wrap(err)
}