Skip to content

Commit

Permalink
satellite/overlay: change % of data going to new nodes from 5 to 1
Browse files Browse the repository at this point in the history
This parameter is marked deprecated, but as far as I can tell it is
still the place to make the change we want, until this concern is
translated to placement definitions.

Refs: #6011
Change-Id: Iafa7d58e58429dd961d8cd1405fb258ddc398e08
  • Loading branch information
thepaul authored and Storj Robot committed Jan 22, 2024
1 parent cb2125c commit 506f284
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion satellite/overlay/config.go
Expand Up @@ -42,7 +42,7 @@ type AsOfSystemTimeConfig struct {
// NodeSelectionConfig is a configuration struct to determine the minimum
// values for nodes to select.
type NodeSelectionConfig struct {
NewNodeFraction float64 `help:"the fraction of new nodes allowed per request (DEPRECATED: use placement definition instead)" releaseDefault:"0.05" devDefault:"1"`
NewNodeFraction float64 `help:"the fraction of new nodes allowed per request (DEPRECATED: use placement definition instead)" releaseDefault:"0.01" devDefault:"1"`
MinimumVersion string `help:"the minimum node software version for node selection queries" default:""`
OnlineWindow time.Duration `help:"the amount of time without seeing a node before its considered offline" default:"4h" testDefault:"1m"`
DistinctIP bool `help:"require distinct IPs when choosing nodes for upload" releaseDefault:"true" devDefault:"false"`
Expand Down
2 changes: 1 addition & 1 deletion satellite/satellite-config.yaml.lock
Expand Up @@ -872,7 +872,7 @@ identity.key-path: /root/.local/share/storj/identity/satellite/identity.key
# overlay.node.minimum-version: ""

# the fraction of new nodes allowed per request (DEPRECATED: use placement definition instead)
# overlay.node.new-node-fraction: 0.05
# overlay.node.new-node-fraction: 0.01

# the amount of time without seeing a node before its considered offline
# overlay.node.online-window: 4h0m0s
Expand Down

1 comment on commit 506f284

@storjrobot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit has been mentioned on Storj Community Forum (official). There might be relevant details there:

https://forum.storj.io/t/unvetted-vetted-node-traffic/23086/11

Please sign in to comment.