Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uplink hangs on malformed url #1043

Closed
daddyo opened this issue Jan 11, 2019 · 2 comments
Closed

uplink hangs on malformed url #1043

daddyo opened this issue Jan 11, 2019 · 2 comments
Labels
Bug Something isn't working

Comments

@daddyo
Copy link

daddyo commented Jan 11, 2019

To reproduce, invoke uplink with single slash after protocol descriptor

uplink cp ~/keybase_amd64.deb sj:/foo/keybase_amd64.deb

Notice that 'sj:/foo' should be 'sj://foo'

The command works correctly when URL is correctly formed.

Local build on Ubuntu 18.04.1

14:58 $ git log -1
commit 273c3924ca9d6a3b6effebded89ea2e8a08d00e7 (HEAD -> master, origin/master, origin/HEAD)
Author: Bill Thorp <bill3000@hotmail.com>
Date: Fri Jan 11 13:15:49 2019 -0500
@egonelbre egonelbre added the Bug Something isn't working label Jan 20, 2019
@stefanbenten
Copy link
Contributor

@littleskunk FYI

@stefanbenten
Copy link
Contributor

Hello @daddyo,
good news!
This issue is fixed with the latest versions 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants