Storagenode-updater ignores version.check-interval parameter

[MaxMaximus]

Hello.

I wanted to reduce frequency of checks for a new version.
I found corresponding parameter in the config.yaml:

# Interval to check the version
# version.check-interval: 15m0s

I removed # and replaced default value "15m0s" by "3h0m0s", saved config.yaml, restarted Storagenode-updater service.
But it still does check for a new versions each 15 min (default). Also looks like Storagenode-updater do each ver check twice? Or at least duplicate logs entries about it:

2020-01-19T02:33:49.133+0300	INFO	Stop/Shutdown request received.
2020-01-19T02:33:51.472+0300	INFO	Configuration loaded from: C:\Program Files\Storj\Storage Node\config.yaml
2020-01-19T02:33:51.495+0300	INFO	Invalid configuration file key: storage.allocated-disk-space
2020-01-19T02:33:51.495+0300	INFO	Invalid configuration file key: storage.allocated-bandwidth
2020-01-19T02:33:51.495+0300	INFO	Invalid configuration file key: contact.external-address
2020-01-19T02:33:51.496+0300	INFO	Invalid configuration file key: server.debug-log-traffic
2020-01-19T02:33:51.496+0300	INFO	Invalid configuration file key: server.private-address
2020-01-19T02:33:51.496+0300	INFO	Invalid configuration file key: operator.email
2020-01-19T02:33:51.496+0300	INFO	Invalid configuration file key: server.address
2020-01-19T02:33:51.496+0300	INFO	Invalid configuration file key: storage.path
2020-01-19T02:33:51.496+0300	INFO	Invalid configuration file key: operator.wallet
2020-01-19T02:33:51.496+0300	INFO	Invalid configuration file value for key: log.caller
2020-01-19T02:33:51.655+0300	INFO	Downloading versions from https://version.storj.io
2020-01-19T02:33:52.292+0300	INFO	storagenode version is up to date
2020-01-19T02:33:52.292+0300	INFO	Downloading versions from https://version.storj.io
2020-01-19T02:33:52.437+0300	INFO	storagenode-updater version is up to date
2020-01-19T02:48:51.646+0300	INFO	Downloading versions from https://version.storj.io
2020-01-19T02:48:52.306+0300	INFO	storagenode version is up to date
2020-01-19T02:48:52.306+0300	INFO	Downloading versions from https://version.storj.io
2020-01-19T02:48:52.458+0300	INFO	storagenode-updater version is up to date
2020-01-19T03:03:51.641+0300	INFO	Downloading versions from https://version.storj.io
2020-01-19T03:03:52.223+0300	INFO	storagenode version is up to date
2020-01-19T03:03:52.223+0300	INFO	Downloading versions from https://version.storj.io
2020-01-19T03:03:52.368+0300	INFO	storagenode-updater version is up to date
.................

P.S.
I currently use latest windows GUI version v. 0.29.3.

[egonelbre]

storagenode-updater and storagnode have two different flags. The messages you are seeing come from the storagenode-updater not storagenode. storagenode-updater uses flag --check-interval.

[MaxMaximus]

Are there two separate udaters running?
"storagenode-updater" dedicated to version monitoring and SW updates and buit-in updater in the main "storagenode" service?

[egonelbre]

@MaxMaximus not really, they serve different purposes, however I agree that they could be improved.

storagenode-updater is dedicated to seeing whether there are updates available and automatically updates storagenode-updater itself and storagenode.

storagenode version check is used in the dashboard to show whether there are new versions available. It doesn't do any updating on its own.

Currently we still need both because not all OS-s have storagenode-updater and we need to signal the operators somehow that they should update.

[MaxMaximus]

OK, make sense then.
I have tried --check-interval option and it works fine for storagenode-updater both as a command line parameter and from config.yaml.

But wouldn't it be better to use same parameter for both parts? They set actually same thing - how often to check server for a new ver of client.
Or you plan to remove ver check code from storagenode (after addition of storagenode-update in all packages) and corresponding config parameter later?

[egonelbre]

Sorry for not noticing the question later. Yes, probably in a future date the version-checker interval won't be needed.

[storjrobot]

This issue has been mentioned on Storj Community Forum (official). There might be relevant details there:

https://forum.storj.io/t/updater-interval/19163/5