[storagenode] Check whether we can drop support for v0 pieces

[profclems]

Currently we still have to deal with V0pieces. We only know they still exist because of a node a month or so ago that hit a bug dealing with a filesystem error on a v0 piece. It would be really nice to get rid of all the code. We don't have any metrics to track v0 pieces in the network.

We should figure out a way or maybe write something into Filewalker to check whether we can drop v0 support

[revyte]

Is this the topic you are referring to? https://forum.storj.io/t/your-node-is-disqualified-from-us-satellite-why-is-that-for/21539/13
If yes, it could be out of context, but it's also good to make sure they are or are not longer in existence.

I've seen a similar warnings in my log but, at least in my case, this should be another thing.

2023-04-13T18:47:32.156+0200	INFO	piecedeleter	delete piece sent to trash	{"Satellite ID": "12EayRS2V1kEsWESU9QMRseFhdxYxKicsiFmxrsLZHeLUtdps3S", "Piece ID": "WTFFJWB6KJVDFREF432YFOZCJ3VFDXTTQOQWO2GUIGH2U7K3LSOQ"}
2023-04-13T18:47:32.156+0200	WARN	pieces	failed to migrate v0 piece. Piece may not be recoverable
2023-04-13T18:47:32.156+0200	ERROR	piecedeleter	could not send delete piece to trash	{"Satellite ID": "12EayRS2V1kEsWESU9QMRseFhdxYxKicsiFmxrsLZHeLUtdps3S", "Piece ID": "WTFFJWB6KJVDFREF432YFOZCJ3VFDXTTQOQWO2GUIGH2U7K3LSOQ", "error": "pieces error: filestore error: file does not exist", "errorVerbose": "pieces error: filestore error: file does not exist\n\tstorj.io/storj/storage/filestore.(*blobStore).Stat:105\n\tstorj.io/storj/storagenode/pieces.(*BlobsUsageCache).pieceSizes:245\n\tstorj.io/storj/storagenode/pieces.(*BlobsUsageCache).Trash:290\n\tstorj.io/storj/storagenode/pieces.(*Store).Trash:388\n\tstorj.io/storj/storagenode/pieces.(*Deleter).deleteOrTrash:185\n\tstorj.io/storj/storagenode/pieces.(*Deleter).work:135\n\tstorj.io/storj/storagenode/pieces.(*Deleter).Run.func1:72\n\tgolang.org/x/sync/errgroup.(*Group).Go.func1:75"}

[profclems]

This is really helpful @revyte!

[storjrobot]

This issue has been mentioned on Storj Community Forum (official). There might be relevant details there:

https://forum.storj.io/t/piecedeleter-could-not-send-delete-piece-to-trash-error-pieces-error-v0pieceinfodb-sql-no-rows-in-result-set/15708/15