fix crash on Ship_HullDamage call (event_name "ShpHullDamage")

[q4a]

How to reproduce crash:
Load attached save and fight with enemy in sea.
Open_sea-SAVE.zip
Crash sometimes happens when cannonballs hit your ship.

How it looks like in debugger:

[mitrokosta]

This bug seems to have been around for a while, but only Hammie's changes made it apparent.

[espkk]

TEHO that I have in steam uses that additional 'a' parameter 🤔

Is this a matter of bad versioning? @mitrokosta

[mitrokosta]

TEHO that I have in steam uses that additional 'a' parameter 🤔

Is this a matter of bad versioning? @mitrokosta

No, it's not. The only usage is aref aCharacter = GetEventData(); // владелец ядра (от кого прилетело)
But then this aCharacter is never used. q4a updated the scripts in sd-teho-public, removing this usage.
Btw with Hammie's changes this event would crash the game anyway because of parameter mismatch. So nothing really changes if you use newer versions of the engine.

[espkk]

TEHO that I have in steam uses that additional 'a' parameter 🤔
Is this a matter of bad versioning? @mitrokosta

No, it's not. The only usage is aref aCharacter = GetEventData(); // владелец ядра (от кого прилетело) But then this aCharacter is never used. q4a updated the scripts in sd-teho-public, removing this usage. Btw with Hammie's changes this event would crash the game anyway because of parameter mismatch. So nothing really changes if you use newer versions of the engine.

I can see those

	int iHullNum = GetEventData(); // номер ноды в которую прилетело
	float x = GetEventData();
	float y = GetEventData();
	float z = GetEventData();
	float fDamage = GetEventData();
	aref rCharacter = GetEventData(); // в кого прилетело
	aref aCharacter = GetEventData(); // владелец ядра (от кого прилетело)
	string HullName = GetEventData(); // имя ноды в которую прилетело

both rCharacter and aCharacter are aref. iBallOwner (int) is obviously invalid here, though reading both attributes from stack would cause the same kind of crash

[mitrokosta]

TEHO that I have in steam uses that additional 'a' parameter 🤔
Is this a matter of bad versioning? @mitrokosta

No, it's not. The only usage is aref aCharacter = GetEventData(); // владелец ядра (от кого прилетело) But then this aCharacter is never used. q4a updated the scripts in sd-teho-public, removing this usage. Btw with Hammie's changes this event would crash the game anyway because of parameter mismatch. So nothing really changes if you use newer versions of the engine.

I can see those

	int iHullNum = GetEventData(); // номер ноды в которую прилетело
	float x = GetEventData();
	float y = GetEventData();
	float z = GetEventData();
	float fDamage = GetEventData();
	aref rCharacter = GetEventData(); // в кого прилетело
	aref aCharacter = GetEventData(); // владелец ядра (от кого прилетело)
	string HullName = GetEventData(); // имя ноды в которую прилетело

both rCharacter and aCharacter are aref. iBallOwner (int) is obviously invalid here, though reading both attributes from stack would cause the same kind of crash

This is why we removed aref aCharacter = GetEventData(); // владелец ядра (от кого прилетело) line

[espkk]

I see, that's exactly my question