Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compability with Rg.Plugins.Popup #21

Closed
nathan1658 opened this issue Feb 2, 2019 · 6 comments
Closed

Compability with Rg.Plugins.Popup #21

nathan1658 opened this issue Feb 2, 2019 · 6 comments

Comments

@nathan1658
Copy link

Hello, the plugin is excellent and my app do enjoy the convenience on all your hard effort.
This issue might be out of the scope, however I found that if I try to view the PhotoBrowser inside the pop up screen, nothing happened on iOS but works on android. I'm beginner of iOS developer but i suspect there might be something related to the code below in MyMWPhotoBrowser:
UIApplication.SharedApplication.KeyWindow.RootViewController.PresentViewController(new UINavigationController(browser), true, null);

Any idea to work with it? Thanks!

https://github.com/rotorgames/Rg.Plugins.Popup

@didacvm
Copy link
Contributor

didacvm commented Feb 20, 2019

I'm having the same issue.
Log output:
Warning: Attempt to present <UINavigationController: 0x1124e0c00> on <RgPopupPlatformRenderer: 0x1165511a0> which is already presenting <Rg_Plugins_Popup_IOS_Renderers_PopupPageRenderer: 0x1165489c0>

And if I popup all RGPopups before:
Warning: Attempt to present <UINavigationController: 0x1541fb800> on <Xamarin_Forms_Platform_iOS_PlatformRenderer: 0x153d909f0> whose view is not in the window hierarchy!

@didacvm
Copy link
Contributor

didacvm commented Feb 20, 2019

@nathan1658
I actually solved it.
Plese refer to the pull request:
#22
Thanks.

@nathan1658
Copy link
Author

@didacvm
Nice thanks for the quick solution!

@LeoJHarris
Copy link
Contributor

@didacvm I saw this issue got merged. Is this working now? Can the issue be closed?

@didacvm
Copy link
Contributor

didacvm commented Mar 26, 2019

@LeoJHarris Yes it's working, the issue can be closed.

@mimunoz
Copy link

mimunoz commented Aug 30, 2019

Hi all,
this change has been released in Nuget.org? I ask because I've the same issue and Nuget.org show this
image

Regards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants