Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Making Session Management More Usable #61

Closed
rdegges opened this issue Apr 1, 2015 · 2 comments
Closed

Making Session Management More Usable #61

rdegges opened this issue Apr 1, 2015 · 2 comments

Comments

@rdegges
Copy link
Contributor

rdegges commented Apr 1, 2015

Right now, this library initializes its own session stuff as req.session. This is a problem for many people, as most node libraries initialize their own session stuff under the same name -- this causes issues.

What I'd like to do is migrate all Stormpath session stuff to req.stormpathSession, this way there will be no chance of conflict for non-auth related sessions.

I've got about 99% of this code ready to ship, but the CSURF library doesn't currently support anything other than req.session, which is a blocker for this.

I've opened a ticket on the CSURF library page: expressjs/csurf#66

If the author gives me the go ahead, I'll submit a PR to their project, and then once released, push the changes into this library.

@rdegges
Copy link
Contributor Author

rdegges commented Apr 3, 2015

My PR is finished for the CSURF library, it can be found here: expressjs/csurf#67

Once this is merged in and released, I'll update our csurf dependencies here, and cut a new release with the above fixes included.

@rdegges
Copy link
Contributor Author

rdegges commented Apr 8, 2015

All merged, cut, and released!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant