Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTML comments #5

Closed
skilar opened this issue Aug 20, 2021 · 2 comments
Closed

Add support for HTML comments #5

skilar opened this issue Aug 20, 2021 · 2 comments

Comments

@skilar
Copy link

skilar commented Aug 20, 2021

This is a great package! Thanks for writing it.

I've encountered some HTML with comments, such as <!-- Main -->, and always get the following error: undefined method 'extract_span_xml_comment'. It would be helpful if kramdown-prismic could support this in some way instead of failing. I don't actually need the comments converted — stripping them would be all right.

@francois2metz
Copy link
Collaborator

Thanks for reporting it @skilar. This is partially a regression of the 0.3 version. I have released the version 0.3.3 to fix it.

@skilar
Copy link
Author

skilar commented Aug 20, 2021

That was fast! Wow! Thank you, @francois2metz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants