Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: axios is no longer a dependency #263

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

Dawntraoz
Copy link
Contributor

@Dawntraoz Dawntraoz commented Dec 22, 2022

feat: remove axios in favor of fetch API
fix: include changes from the Pooya PR to align with the cypress tests #261

@Dawntraoz Dawntraoz marked this pull request as ready for review December 23, 2022 13:24
Copy link
Contributor

@alexjoverm alexjoverm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks perfect, awesome work @Dawntraoz 👏

@roberto-butti
Copy link
Contributor

Looks great!

@alvarosabu
Copy link
Contributor

I'm really interested in this one, @roberto-butti any chance to merge it soon?

@Dawntraoz Dawntraoz merged commit 4100f5b into main Jan 11, 2023
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Dawntraoz Dawntraoz deleted the feat/remove-axios-add-typescript branch March 16, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants