Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Resolve References in getStory() #10

Closed
LTDanwithlegs opened this issue Apr 15, 2020 · 5 comments
Closed

No Resolve References in getStory() #10

LTDanwithlegs opened this issue Apr 15, 2020 · 5 comments

Comments

@LTDanwithlegs
Copy link
Contributor

On line 272 of src/Storyblok/Client.php, the options are being built for us. This does not allow us to pass in options like resolve_relations to have global component content returned with the call to get a story.

We need a way to pass in the string of the global component to resolve when requesting a story as mentioned in this walkthrough: https://www.storyblok.com/tp/global-components-references#resolving-the-relationship-with-the-api
@LTDanwithlegs
Copy link
Contributor Author

Potential solution in this pull request: #11

@LTDanwithlegs
Copy link
Contributor Author

@onefriendaday - Just circling back around. Any update on this? Thanks!

@ademarCardoso
Copy link
Member

Hello @danielbrooks4p , thanks for reporting a problem :) , or the Pull Request you mentioned above has been merged 👍

@andyjaar
Copy link
Contributor

andyjaar commented Jul 3, 2020

I have made a similar Pull Request (#14) for getStories()

@ademarCardoso
Copy link
Member

Hi @andyjaar Thanks to send a PR and comented at this issue, I thought the problem had been solved, let's check and if possible merge your PR, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LTDanwithlegs @andyjaar @ademarCardoso