Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing private figma support #38

Closed
hannahjin opened this issue Apr 9, 2020 · 3 comments
Closed

Releasing private figma support #38

hannahjin opened this issue Apr 9, 2020 · 3 comments

Comments

@hannahjin
Copy link

Hi! I see that you recently added private figma support. I am really excited about this feature. I was trying to set it up today in my project only to realize that it hasn't been released yet. Since this is monorepo, I am unable to yarn install the latest using git reference. I was wondering if you have a timeline in mind when you will release it. Thank you!

@pocka
Copy link
Collaborator

pocka commented Apr 9, 2020

I've just released v5.3.0-alpha.0, which includes private Figma file support. You can install it by yarn add -D storybook-addon-designs@alpha.

@pocka pocka closed this as completed Apr 9, 2020
@hannahjin
Copy link
Author

Thank you!

@pocka
Copy link
Collaborator

pocka commented May 21, 2020

Hi all,

Figma announced an official private embeds! So you no longer need to include a token to use API in JavaScript code 🔒

I'll remove the experimental private embeds support that was introduced in v5.3.0-alpha.0 by stable release. If you're using that one, please switch to official private embeds.

To embed a private file is now super easy: copy-and-paste an URL of your Figma file (or Frame), just same as for public files. Figma app inside <iframe> automatically detects whether it's a private then show users a sign-in UI if needed.

I tested the feature at this repo's example with my private files and confirmed it works as intended. If you encountered a bug, please create a new issue with clear title and description (e.g. "Figma private embeds' sign-in button doesn't work").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants