Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

fix: no knobs after select #60

Merged
merged 3 commits into from
Oct 24, 2019
Merged

Conversation

nekitk
Copy link
Contributor

@nekitk nekitk commented Aug 13, 2019

Fixes #59
Fixes #30

  • Storybook fails to render next knobs when you pass to select options object with an empty key. Replaced empty key with --
  • Choosing empty option was setting prop value to -- which is undesired (because it is truthy). We can't set it to undefined for now (addon-knobs select should be able to have undefined options. storybookjs/storybook#4487), so I replaced it with null
  • Empty option in select was available even for required props. Changed it so it is added only for props that are not required.

@sami616
Copy link

sami616 commented Aug 14, 2019

This would be a great addition. As a work around I am passing an empty string as the default value.

@RoyalHunt
Copy link

Waiting this pr for a while. Any progress?

@vercel vercel bot requested a deployment to staging October 19, 2019 10:36 Abandoned
@vercel
Copy link

vercel bot commented Oct 19, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

@vercel vercel bot requested a deployment to staging October 24, 2019 12:51 Abandoned
@vercel
Copy link

vercel bot commented Oct 24, 2019

Deployment failed with the following error:

Your `package.json` file is missing a `build` property inside the `script` property.

* upgraded storybook to support undefined in select
@vercel vercel bot requested a deployment to staging October 24, 2019 12:57 Abandoned
@vercel
Copy link

vercel bot commented Oct 24, 2019

Deployment failed with the following error:

Your `package.json` file is missing a `build` property inside the `script` property.

@nekitk nekitk merged commit bd18398 into storybook-eol:master Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Knobs which comes after select disappear oneOf smart knob returns "--" as value of empty option
4 participants