-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Adding builder-vite to main config file launches actual app instead of playground #446
Comments
Can confirm I'm also seeing this issue. Running |
Hi, I think I am experiencing the same problem here. Initially, I thought this might be related to me using yarn (canary, I think), but the same thing happens with plain old npm. |
Can confirm, I'm also seeing this issue. |
Thanks for providing a reproduction, @SamuelPoulin, that was super helpful since I don't experience this in my own app or in the examples in this repo (I don't know why). I've found the reason this is happening, and we should have a new version with a fix out soon. |
Thanks everyone. A fix for this has been released in |
I bumped the version of builder-vite in https://github.com/SamuelPoulin/vite-react-typescript-storybook-minimal and unfortunately I'm still getting this problem when uncommenting the builder... |
Thanks, I screwed up the config it seems. For now, you can work around this by using |
What version of
vite
are you using?3.0.0
System info and storybook versions
System:
OS: Linux 5.10 Ubuntu 20.04.4 LTS (Focal Fossa)
CPU: (16) x64 Intel(R) Core(TM) i7-10700 CPU @ 2.90GHz
Binaries:
Node: 16.15.1 - /usr/bin/node
Yarn: 1.22.18 - /usr/bin/yarn
npm: 8.11.0 - /usr/bin/npm
Describe the Bug
Hello, I have created a minimal repo here to reproduce the bug. Here is how to do it:
Steps:
1- Clone the repo
2- Execute
yarn
inside the repo3- Execute
yarn storybook
inside the repo4- Visit http://localhost:6006/ and see that the storybook playground is working just fine
5- Stop
yarn storybook
6- Go to
.storybook/main.ts
7- Uncomment lines 10-12 to enable builder-vite
8- Relaunch
yarn storybook
9- The page hosted at localhost:6006 now displays the actual app instead of the playground
Link to Minimal Reproducible Example
: https://github.com/SamuelPoulin/vite-react-typescript-storybook-minimal
Participation
The text was updated successfully, but these errors were encountered: