Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .jsx extension #59

Closed
mharward-tw opened this issue Dec 2, 2021 · 3 comments
Closed

Support .jsx extension #59

mharward-tw opened this issue Dec 2, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@mharward-tw
Copy link

At the moment, this plugin does not support .jsx extension, which is commonly used for react projects. This leads to the plugin not being usable in projects that use this convention.

As a dev who would love to use this to ensure consistency in our .stories.jsx files, adding this extension would be very useful.

Change would require adding the extension into https://github.com/storybookjs/eslint-plugin-storybook/blob/0c413c9497b487234356b5dca0f460f98ce6c108/tools/update-configs.ts

@yannbf
Copy link
Member

yannbf commented Dec 2, 2021

Hey @mharward-tw thank you so much for catching that! It was just overlooked. Could you please try version 0.5.2? Should be fixed now.
Thank you!

@yannbf yannbf added the bug Something isn't working label Dec 2, 2021
@mharward-tw
Copy link
Author

Thanks @yannbf, much appreciated and thank you for such a quick turn around. I've just checked the new version and it works like a charm! Thank you :)

@yannbf
Copy link
Member

yannbf commented Dec 2, 2021

Alright awesome! Thanks once again and have a great one! I hope you like using this plugin and keep the feedback coming <3

@yannbf yannbf closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants