Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook/no-uninstalled-addons fails with locally references file addons #97

Closed
alopix opened this issue Jul 12, 2022 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@alopix
Copy link

alopix commented Jul 12, 2022

Describe the bug

The latest version 0.6.0 introduces storybook/no-uninstalled-addons which will fail if you use file path addons.

[eslint] storybook/main.js
[eslint] 91:5 error
The ./my-addon/preset.cjs is not installed. Did you forget to install it? storybook/no-uninstalled-addons

To Reproduce
Steps to reproduce the behavior:

  1. Add an addon to your main.js array using a relative file path, e.g. addons: ['./my-addon/preset.cjs']
  2. Run eslint
  3. See error

Expected behavior
Local file references should be ignored since there is no need to install them.

@yannbf
Copy link
Member

yannbf commented Jul 12, 2022

Hey @alopix thanks for surfacing this! We'll take that into account and come up with a fix. cc @andrelas1

@yannbf yannbf added the bug Something isn't working label Jul 12, 2022
@yannbf
Copy link
Member

yannbf commented Jul 12, 2022

Hey @alopix I just released v0.6.1 containing a fix for this. Thank you so much for helping make this happen!

@yannbf yannbf closed this as completed Jul 12, 2022
@alopix
Copy link
Author

alopix commented Jul 12, 2022

That was brilliantly fast, thank you so much!

@yannbf
Copy link
Member

yannbf commented Jul 12, 2022

Thank you for using this plugin and more so for creating this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants