Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR issues #558

Closed
dannyhw opened this issue Feb 23, 2024 · 4 comments
Closed

HMR issues #558

dannyhw opened this issue Feb 23, 2024 · 4 comments

Comments

@dannyhw
Copy link
Member

dannyhw commented Feb 23, 2024

Describe the bug
There are sometimes issues where HMR doesn't correctly trigger in v7 when editing stories, in these cases a reload is required to see the changes.

This seems to be an issue mainly for stories files. Still investigating the root cause.

@robin-ambachtsheer
Copy link

This seems related so just leaving as a comment here. After an HMR update on the iOS simulator, when trying to use the story search the app crashes. It works fine when doing a hard refresh.

I also found that the HMR does seem to trigger a refresh, but it just reloads with the old story code (updates in components do seem to come through). Also only on iOS for me, on Android it does seem to update the stories correctly.

Might be worth noting I'm using Expo.

@dannyhw
Copy link
Member Author

dannyhw commented Mar 6, 2024

@robin-ambachtsheer hey, yeah this has been a tough one to debug but hoping to have a fix sometime soon.

@dannyhw
Copy link
Member Author

dannyhw commented Mar 7, 2024

@robin-ambachtsheer please try 7.6.16, this should be fixed now :)

@dannyhw dannyhw closed this as completed Mar 7, 2024
@robin-ambachtsheer
Copy link

Seems to be working perfectly now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants