Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

fix issue where new repo didn't set matching source branch #87

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

stephenhmarsh
Copy link
Contributor

this fixes #86 for me

@stephenhmarsh
Copy link
Contributor Author

It seems strange that the "source branch" flag doesn't (currently) mean something like "a different branch of your project to build the storybook from, rather than the current branch." This is what I would assume from the name and the docs.

Instead, the command on line 76 (git push --force --quiet ${GIT_URL} ${SOURCE_BRANCH}:${TARGET_BRANCH}) uses "source branch" in the context of the new, temporary repo in OUTPUT_DIR.

I'm wondering if there shouldn't also be a much earlier step to git checkout <source-branch> before anything is built?

@jimmyandrade jimmyandrade merged commit 9d907ca into storybook-eol:master Jun 15, 2021
@jimmyandrade jimmyandrade self-assigned this Jun 15, 2021
@hipstersmoothie
Copy link
Contributor

🚀 PR was released in v2.8.10 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released This issue/pull request has been released.
Development

Successfully merging this pull request may close these issues.

The --source-branch Flag Throws Error
3 participants