Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iteration on the Copy Canvas Link button #16757

Open
MichaelArestad opened this issue Nov 22, 2021 · 9 comments
Open

Iteration on the Copy Canvas Link button #16757

MichaelArestad opened this issue Nov 22, 2021 · 9 comments
Assignees

Comments

@MichaelArestad
Copy link
Contributor

We were taking a look at the "Copy canvas link" and the "Open canvas in new tab" buttons this morning and @ndelangen suggested we might combine those two into a dropdown.

There are a few benefits that jump out at me:

  1. It frees up a little space in the toolbar.
  2. The labels are bit clearer.
  3. We could add more actions as well like "Copy story link."

On the flip side:

  1. It adds an extra click.

I mocked it up quickly to see how it feels:

Tooltip link

I am still a bit on the fence with this one. It could definitely work.

Does the menu add clarity?
Does the extra click get in the way?

Are you able to assist to bring the feature to reality?
Yep!

@ndelangen
Copy link
Member

I think this is the right way forwards, sharing (which is the primary use-case for all these function) are already a multi-step process on most websites. Let's do this. Do we have a pretty "share" icon?

@yannbf
Copy link
Member

yannbf commented Nov 23, 2021

I like it! It's much more informative although it requires an extra click

@MichaelArestad
Copy link
Contributor Author

Do we have a pretty "share" icon?
@ndelangen We have a fairly standard share icon:

image

@ndelangen
Copy link
Member

LGTM 👍 Let's proceed to use that then.

@yannbf
Copy link
Member

yannbf commented Apr 6, 2022

What about making this even nicer with a QR code generation feature? It's pretty handy to check stuff on the phone simultaneously:

image

@MichaelArestad
Copy link
Contributor Author

@yannbf I think a QR code could be super useful. Here's an updated screenshot:

Tooltip link

I didn't mock up the full QR code flow yet because I would like to focus on that in a followup issue.

@MichaelArestad
Copy link
Contributor Author

Updated proposal: This now has the correct icons

copy menu

@ndelangen
Copy link
Member

@MichaelArestad what if the QR code just was in the dropdown already?
So you click on the share icon, and can immediately scan the QR code.

@MichaelArestad
Copy link
Contributor Author

@ndelangen We could do something like that for sure. I left it out of the latest mockup because I think that feature should get it's own issue/proposal so we can fully work it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants