Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mono Repo: Add preserveSymlinks feature to SB Angular Builder #17601

Open
ghost opened this issue Mar 1, 2022 · 0 comments
Open

Mono Repo: Add preserveSymlinks feature to SB Angular Builder #17601

ghost opened this issue Mar 1, 2022 · 0 comments

Comments

@ghost
Copy link

ghost commented Mar 1, 2022

Is your feature request related to a problem?
After upgrading to Angular 13 and Storybook 6.4, the symlinks to another angular library in the same mono repository doesn't work anymore.

Repository to analyse the error => https://github.com/keth-dev/lerna-storybook-ng-libs

Describe the solution you'd like
Add preserveSymlinks options to @storybook/angular:start-storybook just like angular builder supports.

Describe alternatives you've considered
Alternatively, customizing webpack config not to resolve symlinks works. However, it is better to configure using SB angular builder.
https://webpack.js.org/configuration/resolve/#resolvesymlinks

module.exports = {
  webpackFinal: (config) => {
    return {
      ...config,
      resolve: {
        ...config.resolve,
        // Preserve symlinks (i.e. DO NOT resolve).
        // // When enabled, symlinked resources are resolved to their real path, not their symlinked location. This causes module resolution to fail when using 'npm link'
        symlinks: false
      }
    }
  },

Are you able to assist to bring the feature to reality?
No

@ghost ghost changed the title Mono Repo: Add preserveSymlinks feature to start-storybook builder Mono Repo: Add preserveSymlinks feature to storybook builders Mar 1, 2022
@ghost ghost changed the title Mono Repo: Add preserveSymlinks feature to storybook builders Mono Repo: Add preserveSymlinks feature to SB Angular Builder Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants