Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stories to exist at the same level as nested folders #1859

Closed
tbredin opened this issue Sep 18, 2017 · 2 comments
Closed

Allow stories to exist at the same level as nested folders #1859

tbredin opened this issue Sep 18, 2017 · 2 comments

Comments

@tbredin
Copy link

tbredin commented Sep 18, 2017

Picking up on a request made by @psimyn in #151 (comment)

Initially this was one of the first patterns I attempted upon picking up Storybook, and it until I found @psimyn's comment it wasn't very clear why the below pattern didn't work as expected:

storiesOf('Grid', module)
    ...

storiesOf('Grid/Examples', module)
    ...

Expected: A single Grid folder containing some stories for my components, and then a nested Examples folder containing some usage examples.

Result: Two seperate Grid folders.

Depending whether we think this is worth supporting ... Even though the example in the docs doesn't at all present the above setup, I think potentially it'd be good to make it clearer in the docs that it can't be done currently. I think it's a pattern that's likely to be commonly assumed by developers when talking about nesting folders; what does everyone think?

View the relevant nesting documentation

@igor-dv
Copy link
Member

igor-dv commented Sep 18, 2017

It's already implemented and will be released with 3.3 😉

@ndelangen
Copy link
Member

ndelangen commented Sep 20, 2017

I'm closing this issue, 3.3.0-alpha.0 is on npm and can be tested. So if you want to try this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants