Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The contrast ratio between foreground and background colors of the links under 'getting started' section is 2.92: 1 which is less than required ratio 4.5:1. #23643

Closed
msftedad opened this issue Jul 28, 2023 · 6 comments

Comments

@msftedad
Copy link

Describe the bug

The contrast ratio between foreground and background colors of the links under 'getting started' section is 2.92: 1 which is less than required ratio 4.5:1.

Severity: 1

To Reproduce

Repro Steps: 

  1. Open URL: “Overview - Docs ⋅ Storybook (windows.net)” and sign in with valid credentials. 
  2. In left navigation select in “App header” under components and invoke it. 
  3. Now Run the Color Contrast Anayzer tool for the links.
  4. Verify whether the ontrast ratio between foreground and background colors of the links under 'getting started' is meeting required ratio 4.5:1 or not.

System

Windows: Win11 Enterprise
OS: Version 22H2 (OS Build 22621.1992) 
Edge Version: Version 114.0.1823.51 (Official build) (64-bit) 

URL:URL: Overview - Docs ⋅ Storybook (windows.net)

Additional context

Expected result:
Ensure the contrast between foreground and background colors meets WCAG 2 AA contrast ratio thresholds.

Attachments:

MicrosoftTeams-image (8)
@chocoscoding
Copy link
Contributor

chocoscoding commented Aug 14, 2023

@msftedad i want to work fix this, can i be assinged to fix this ?

@yannbf
Copy link
Member

yannbf commented Aug 14, 2023

Sure thing @chocoscoding ! I believe you might need to follow up with either @MichaelArestad or @cdedreuille (on vacation right now) about it, as the link might be using colors from the design system tokens

@chocoscoding
Copy link
Contributor

ok, thanks

@cdedreuille
Copy link
Contributor

Thanks a lot for reaching out. That's a great question and a great problem to solve. We are in the process of improving our UI library to make it easier, more accessible and to respect as much as possible all accessibility rules.

The change you are asking is quite a tricky one as it is asking to change one of our main colour from Storybook theming. Realistically I don't think that's a change we can handle right now as this will touch a lot of components but it is something I would love to change in the near future when we are updating our default theme.

@chocoscoding
Copy link
Contributor

@cdedreuille Thanks for answering in such short time during your vacation.
Is there any issue you can recommend me taking on as a good first issue.

Thanks

@cdedreuille
Copy link
Contributor

@chocoscoding I would recommend going into the list of "good first issues" to see if there's something you could help with:
https://github.com/storybookjs/storybook/issues?q=is:open+is:issue+label:%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants