Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: showPanel: false not working (v8.0.0-beta.0) #25900

Closed
aaronadamsCA opened this issue Feb 4, 2024 · 1 comment
Closed

[Bug]: showPanel: false not working (v8.0.0-beta.0) #25900

aaronadamsCA opened this issue Feb 4, 2024 · 1 comment

Comments

@aaronadamsCA
Copy link

Describe the bug

.storybook/manager.ts

import { addons } from "@storybook/manager-api";
import { create } from "@storybook/theming/create";

addons.setConfig({
  showPanel: false,
  theme: create({
    base: "dark",
  }),
});

After upgrading to v8.0.0-beta.0, the addons panel appears when I start Storybook, even though I've turned it off.

I still get a dark theme, which indicates manager.ts is still being read and understood; it's just the showPanel: false setting that isn't being respected.

To Reproduce

https://stackblitz.com/edit/github-izp6au-fo1t1m?file=.storybook%2Fmanager.ts

StackBlitz takes about a year to run Storybook, but the issue does reproduce. You'll have to open up the right pane wide enough to confirm.

screenshot of bug

System

No response

Additional context

No response

@vanessayuenn
Copy link
Contributor

@aaronadamsCA thanks for trying out Storybook 8 beta! Indeed, starting from Storybook 8, showPanel is no longer a valid option. It has instead been split out to bottomPanelHeight: number and rightPanelWidth: number, where the numbers represents the size of the panel in pixels. Here is the relevant migration notes section, and the API docs.

@storybookjs storybookjs locked and limited conversation to collaborators Feb 5, 2024
@vanessayuenn vanessayuenn converted this issue into discussion #25913 Feb 5, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

2 participants