Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook does not process .babelrc extends correctly #2610

Closed
adamchenwei opened this issue Dec 30, 2017 · 3 comments
Closed

Storybook does not process .babelrc extends correctly #2610

adamchenwei opened this issue Dec 30, 2017 · 3 comments

Comments

@adamchenwei
Copy link

Issue details

Please provide issue details here - What did you expect to happen? What happened instead?
I expect npm run storybook to load correctly without errors show in screenshot below

Steps to reproduce

get react-static, produce a site, install storybook-cli globally then getstorybook in the react-static produced base site.

Please provide necessary steps for reproduction of this issue. Describe the exact steps a maintainer has to take to make the problem occur. If the problem is non-trivial to reproduce, please link a repository or provide some code snippets.
https://github.com/nozzle/react-static
(A screencast can be useful for visual bugs, but it is not a substitute for a textual description.)

Please specify which version of Storybook and optionally any affected addons that you're running

@storybook/cli@3.3.3
@ "react": "^16.0.0",

Affected platforms

Win10

Screenshots / Screencast / Code Snippets (Optional)

image

// code here
@Hypnosphi
Copy link
Member

Here's the .babelrc this generator produces:

{
  "extends": "react-static/.babelrc"
}

Looks like we don't process this extends properly

@stale
Copy link

stale bot commented Feb 14, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Feb 14, 2018
@Hypnosphi Hypnosphi added the todo label Feb 17, 2018
@stale stale bot removed the inactive label Feb 17, 2018
@danielduan danielduan changed the title storybook incompatible with react-static? or the other way around? Storybook does not process .babelrc extends correctly Apr 20, 2018
@Hypnosphi
Copy link
Member

Released as 4.0.0-alpha.20

@issue-sh issue-sh bot removed the todo label Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants