Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: types from '@storybook/manager-api' is deprecated - no alternative given #26311

Closed
stevensacks opened this issue Mar 5, 2024 · 2 comments
Labels

Comments

@stevensacks
Copy link
Contributor

stevensacks commented Mar 5, 2024

Describe the bug

According to TypeScript, the {types} import from the addon kit is deprecated.

No alternative has been given. Not mentioned in the migration docs.

Just says:

We need to rename this so it's not compiled to a straight re-export Our globalization plugin can't handle an import and export of the same name in different lines

To Reproduce

Clone the addon kit template, npm i, in the src/manager.ts file there is a typescript deprecation warning on the import.

System

System:
    OS: macOS 14.3.1
    CPU: (12) arm64 Apple M2 Pro
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v20.11.0/bin/yarn
    npm: 10.4.0 - ~/.nvm/versions/node/v20.11.0/bin/npm <----- active
    pnpm: 8.1.0 - ~/.nvm/versions/node/v20.11.0/bin/pnpm
  Browsers:
    Chrome: 122.0.6261.94
    Safari: 17.3.1
  npmPackages:
    @storybook/addon-essentials: 8.0.0-beta.2 => 8.0.0-beta.2 
    @storybook/addon-interactions: 8.0.0-beta.2 => 8.0.0-beta.2 
    @storybook/addon-links: 8.0.0-beta.2 => 8.0.0-beta.2 
    @storybook/blocks: 8.0.0-beta.2 => 8.0.0-beta.2 
    @storybook/components: 8.0.0-beta.2 => 8.0.0-beta.2 
    @storybook/core-events: 8.0.0-beta.2 => 8.0.0-beta.2 
    @storybook/manager: 8.0.0-beta.2 => 8.0.0-beta.2 
    @storybook/manager-api: 8.0.0-beta.2 => 8.0.0-beta.2 
    @storybook/preview: 8.0.0-beta.2 => 8.0.0-beta.2 
    @storybook/preview-api: 8.0.0-beta.2 => 8.0.0-beta.2 
    @storybook/react: 8.0.0-beta.2 => 8.0.0-beta.2 
    @storybook/react-vite: 8.0.0-beta.2 => 8.0.0-beta.2 
    @storybook/testing-library: ^0.2.2 => 0.2.2 
    @storybook/theming: 8.0.0-beta.2 => 8.0.0-beta.2 
    @storybook/types: 8.0.0-beta.2 => 8.0.0-beta.2 
    storybook: 8.0.0-beta.2 => 8.0.0-beta.2

Additional context

Screenshot_2024-03-05_at_15 10 35

@vanessayuenn
Copy link
Contributor

hi @stevensacks this should have been fixed via #26202, shipped in beta-6. Can you please try that out?

@stevensacks
Copy link
Contributor Author

Confirmed fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants