Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: visual-tests-addon Automigration script incorrectly lists package name in main.ts/js file #26814

Closed
McWhorter opened this issue Apr 11, 2024 · 2 comments · Fixed by #26816

Comments

@McWhorter
Copy link

McWhorter commented Apr 11, 2024

Describe the bug

When using the visual-tests-addon automigrate script, the @chromatic-com/storybook dependency is correctly installed. However, the entry in the .storybook/main.* file incorrectly adds @chromatic-dom/storybook. Looks like it's just a typo; should be com, but dom is added.

To Reproduce

Steps:

  1. Configure a new storybook project using the @storybook/test library.
  2. Run the npx storybook automigrate command
  3. When asked: Do you want to run the 'visual-tests-addon' migration on your project?, replay Y

Expect:

  1. The @chromatic-com/storybook dependency in the node_modules directory exists
  2. The @chromatic-com/storybook addon should have been added to the .storybook/main.* file

Actual:

  1. The @chromatic-com/storybook dependency is correctly installed and present
  2. A value of @chromatic-dom/storybook is added to the .storybook/main.* file

System

Storybook Environment Info:

  System:
    OS: macOS 14.4.1
    CPU: (10) arm64 Apple M1 Pro
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.19.0 - ~/.nvm/versions/node/v18.19.0/bin/node
    npm: 8.19.4 - ~/Projects/skylight/node_modules/.bin/npm <----- active
  Browsers:
    Chrome: 123.0.6312.107
    Safari: 17.4.1

Additional context

No response

@ndelangen
Copy link
Member

I'm really sorry for the disruption, that was my typo! 😢

@McWhorter
Copy link
Author

@ndelangen No worries. Looks like it's already fixed in v8.0.8 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants