Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base html tag to the iframe when building #296

Closed
arunoda opened this issue Jul 5, 2016 · 4 comments
Closed

Add base html tag to the iframe when building #296

arunoda opened this issue Jul 5, 2016 · 4 comments
Labels

Comments

@arunoda
Copy link
Member

arunoda commented Jul 5, 2016

Most of the time, we host our storybooks in a subpath of the domain. So resources started with / doesn't work properly.

So, we need add a <base> tag with a proper subdomain (and the path) to the iframe. This needs to be done, when building the storybook.

@arunoda arunoda added the bug label Jul 5, 2016
@roonyh
Copy link
Contributor

roonyh commented Jul 13, 2016

This should go in the head tag right? Adding custom head content is already possible with the head.html

@arunoda
Copy link
Member Author

arunoda commented Jul 13, 2016

Yeah. That's a good idea as well.
But, I need to make this pretty simple by providing an argument when we are building the storybook.

@roonyh
Copy link
Contributor

roonyh commented Jul 13, 2016

Got it. I will work on this.

@arunoda
Copy link
Member Author

arunoda commented Sep 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants