Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-info not showing description and propTypes after adding react-css-modules #3398

Closed
Pavankumar1014 opened this issue Apr 11, 2018 · 8 comments

Comments

@Pavankumar1014
Copy link

Pavankumar1014 commented Apr 11, 2018

If you are reporting a bug or requesting support, start here:

Bug summary

Hi,

I am facing a issue with storybook addon-info that after adding css modules the proptables are not showing the description and proptypes

Steps to reproduce

Component:

`import React from 'react';
import CSSModules from 'react-css-modules';
import styles from './button.css';

class Button extends AbstractComponent {
render() {
return (
<button {...this.props} >

            {this.props.value}
          
        </button>);
}

}

Button.propTypes = {
/** Value to be shown on the button */
value: PropTypes.string.isRequired
}

export default CSSModules(Button,styles)`

Storybook code:

const stories = storiesOf('Button', module); stories.add('Default', withInfo({ text: 'This component defines a clickable button with text.' })(() => ( <Button value="Click" title="Click"></Button> )));

Output:

storybook

@stale
Copy link

stale bot commented May 2, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 2, 2018
@Pavankumar1014
Copy link
Author

Hi stale,

We still stuck with the same issue.

Please let me know if you need more info on this

@stale stale bot removed the inactive label May 3, 2018
@ersel
Copy link
Contributor

ersel commented May 3, 2018

You might need to extend your component using CSSModules before you export it and define the propTypes on top of that.

so instead of this:

export default CSSModules(Button,styles)`//your styles here`;

do something like:

const StyledButton = CSSModules(Button,styles)`//your styles here`;

StyledButton.propTypes = {
    value: PropTypes.string.isRequired
};

export default StyledButton;

@XOP
Copy link

XOP commented May 23, 2018

same issue, extending component doesn't help

@mechabyte
Copy link

Also experiencing the same using @material-ui/core's withStyles decorator

@stale
Copy link

stale bot commented Jul 1, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jul 1, 2018
@stale
Copy link

stale bot commented Jul 31, 2018

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Jul 31, 2018
@ShaiDemri
Copy link

Also experiencing the same using @material-ui/core's withStyles decorator

me too, any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants