Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storysource addon - allow prism configuration #4324

Open
cheshrkat opened this issue Oct 9, 2018 · 4 comments
Open

Storysource addon - allow prism configuration #4324

cheshrkat opened this issue Oct 9, 2018 · 4 comments

Comments

@cheshrkat
Copy link

If you are reporting a bug or requesting support, start here:

Bug or support request summary

Have added Storysource and was expecting to be able to configure Prism syntax highlighting - eg. choose the theme, tweak the highlight style and so on. However I can't find anything in the docs about that - I can see the Prettier settings but nothing about Prism? That all seems hard-coded. This is an issue as the chosen theme is really hard to read and clashes badly with our own design.

Not sure if I'm just missing something, or if this is a feature request...

Steps to reproduce

n/a I think

Please specify which version of Storybook and optionally any affected addons that you're running

  • "@storybook/react": "^3.3.15",
  • "@storybook/addon-storysource": "^3.4.11",

Affected platforms

n/a I think

Where to start

n/a I think

Acceptance criteria

  • Ability to choose theme for Prism when using Storysource
  • Ability to configure/extend the styles applied to the Story tab, eg. the highlight style
@igor-dv
Copy link
Member

igor-dv commented Oct 9, 2018

Nope, it's indeed hardcoded. Want to PR?

@igor-dv
Copy link
Member

igor-dv commented Oct 9, 2018

BTW, @ndelangen and Co are working on overhaul UI changes, where this is addressed, but it will take some time to finish.

@ndelangen
Copy link
Member

The UI overhaul will include theming for all syntax highlighting inside storybook.

#4086

@cheshrkat
Copy link
Author

Thanks for the advice. If I get time I'll take a look at a PR (won't be right away, just to be honest :)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants